Add support for pausing consumers #5066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
force-pushed
the
neil/consumerpause
branch
4 times, most recently
from
d773766
to
81b0221
Compare
|
Have tested:
Good stuff |
neilalexander
force-pushed
the
neil/consumerpause
branch
5 times, most recently
from
e5255cc
to
27e87b6
Compare
ripienaar
approved these changes
Feb 16, 2024
neilalexander
force-pushed
the
neil/consumerpause
branch
from
27e87b6
to
4b945c1
Compare
neilalexander
force-pushed
the
neil/consumerpause
branch
from
4b945c1
to
d4a3758
Compare
|
The unit tests have been updated to use new Therefore they no longer rely on upstream changes in nats.go and the |
ripienaar
reviewed
Feb 21, 2024
server/consumer.go
Outdated
| @@ -1860,6 +1930,22 @@ func (o *consumer) updateConfig(cfg *ConsumerConfig) error { | |||
| o.dtmr = time.AfterFunc(o.dthresh, o.deleteNotActive) | |||
| } | |||
| } | |||
| // heck whether the pause has changed | |||
There was a problem hiding this comment.
Whoops, fixed & rebased!
derekcollison
approved these changes
Feb 24, 2024
…ers.
It can either be set when the consumer is created (but not via a
standard consumer update) or it can be changed later by using the new
`$JS.API.CONSUMER.PAUSE.*.*` API endpoint by sending:
```
{"pause_until": "2024-02-08T19:00:00Z"}
```
Any time that is in the past, or a zero timestamp, is considered as
"unpaused". Once the consumer reaches the `pause_until` time, messages
will start flowing again automatically.
The consumer info will additionally include `paused` (type `bool`) and,
if paused, a `pause_remaining` (type `time.Duration`) to report the pause
status.
Also adds `$JS.EVENT.ADVISORY.CONSUMER.PAUSE.*.*` advisory messages which
are sent when pausing and unpausing (i.e. reaching the pause deadline).
Idle heartbeats continue to be sent while the consumer is paused to
satisfy liveness checks.
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/consumerpause
branch
from
a25f743
to
88b3027
Compare
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
pause_untilconfiguration option for pausing consumers.It can either be set when the consumer is created (but not via a standard consumer update) or it can be changed later by using the new
$JS.API.CONSUMER.PAUSE.*.*API endpoint by sending:Any time that is in the past, or a zero timestamp, is considered as "unpaused". Once the consumer reaches the
pause_untiltime, messages will start flowing again automatically.The consumer info will additionally include
paused(typebool) and, if paused, apause_remaining(typetime.Duration) to report the pause status.Also adds
$JS.EVENT.ADVISORY.CONSUMER.PAUSE.*.*advisory messages which are sent when pausing and unpausing (i.e. reaching the pause deadline).Idle heartbeats continue to be sent while the consumer is paused to satisfy liveness checks.
Before merge: nats-io/nats.go#1554 and
go.modupdated.Signed-off-by: Neil Twigg neil@nats.io