NRG: Avoid panic on corrupted TAV file #5464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
reviewed
May 22, 2024
server/raft.go
Outdated
| @@ -3761,6 +3761,10 @@ func (n *raft) readTermVote() (term uint64, voted string, err error) { | |||
| if err != nil { | |||
| return 0, noVote, err | |||
| } | |||
| if len(buf) < 8 { | |||
There was a problem hiding this comment.
I wonder, should we return an error here?
Though I see that we don't handle errors from readTermVote() anyway, beyond checking if its nil or not.
There was a problem hiding this comment.
An error isn't really actionable in that scenario anyway as we'd still end up resetting back to term 0, in which case we'd might as well just return term 0.
derekcollison
requested changes
May 22, 2024
server/raft.go
Outdated
| @@ -3761,6 +3761,10 @@ func (n *raft) readTermVote() (term uint64, voted string, err error) { | |||
| if err != nil { | |||
| return 0, noVote, err | |||
| } | |||
| if len(buf) < 8 { | |||
There was a problem hiding this comment.
Lets add in constant above.
const termLen = 8
const termVoteLen = termLen + idLenThen use termLen here.
There was a problem hiding this comment.
Also be good to understand how this could have ever happened.
Maybe run full test suite and add in check when raft group goes away to check for this condition.
If the file ends up truncated somehow then we should not try to call `Uint64`, otherwise it will result in an out-of-bounds panic. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/readtermvote
branch
from
3d65afb
to
5fc2caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file ends up truncated somehow then we should not try to call
Uint64, otherwise it will result in an out-of-bounds panic.Signed-off-by: Neil Twigg neil@nats.io