Skip to content

2.3.0 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2018
Merged

2.3.0 #189

merged 2 commits into from
Nov 5, 2018

Conversation

sasbury
Copy link
Contributor

@sasbury sasbury commented Nov 4, 2018

Replaced string in NKey with char[]

@sasbury sasbury requested a review from aricart November 4, 2018 21:36
@coveralls
Copy link

coveralls commented Nov 4, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.07%) to 95.534% when pulling daf45c0 on 2.3.0 into 6c5aca7 on master.

aricart
aricart approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the only issue is the incompatible break with the nkey authentication api, but since a server is not available with that functionality this should be fine.

Updated standard examples to support challenge-response
daf45c0 
Updated readme with better instructions for jars.
Updated CRC test to fix string concat error
@sasbury sasbury merged commit f49af69 into master Nov 5, 2018
@sasbury sasbury deleted the 2.3.0 branch November 18, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aricart aricart aricart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sasbury @coveralls @aricart