Skip to content

Conversation

KevinJBoyer
Copy link
Contributor

Ticket

n/a

Changes

  • Configure isort to follow black formatting conventions

Context for reviewers

  • Without this change there are situations where isort's formatting conflicts with blacks, leading make format-check to fail even after make-format

Testing

You can see an example file that will fail without this change at this PR: navapbc/labs-referral-pilot#11

@KevinJBoyer KevinJBoyer requested a review from doshitan August 25, 2025 13:52
Copy link
Contributor

@doshitan doshitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd rather switch to ruff formatting instead of black+isort, but good to improve the existing stuff where easy.

Can drop the redundant settings before merge.

@KevinJBoyer KevinJBoyer merged commit f02ce6a into main Aug 25, 2025
@KevinJBoyer KevinJBoyer deleted the KevinJBoyer-patch-3 branch August 25, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants