-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit test #996
Fix unit test #996
Conversation
|
0854391
to
3696a71
Compare
3696a71
to
9e0994c
Compare
✅ Build & Test workflow succeed ✅ |
@@ -43,13 +43,13 @@ abstract public class AbstractMultiGrinderTestBase { | |||
|
|||
@Before | |||
public void agentInit() { | |||
agentConfig1 = new AgentConfig.NullAgentConfig(1); | |||
agentConfig1 = new AgentConfig.NullAgentConfig(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ngrinder/ngrinder-core/src/test/java/org/ngrinder/AbstractMultiGrinderTestBase.java
Lines 40 to 42 in 9e0994c
static { | |
System.setProperty("ngrinder.agent.home", "./tmp/agent-home"); | |
} |
I think that setting
ngrinder.agent.home
property as ./tmp/agent-home
could derive resource contention. I wanted to fix it but no time. I'll change it if there is a next time.
console1.addListener(stopReason -> { | ||
// Notice: it couldn't distinguish between a script error or | ||
// timed out of the keepalive connection. | ||
System.out.println("The stop signal is received " + stopReason); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about use private static final Logger LOGGER = LoggerFactory.getLogger(AgentControllerTest.class);
?
fixed some unit tests