Skip to content

Migrated to ktor 2, kotlin 2, JDK 21 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2024
Merged

Migrated to ktor 2, kotlin 2, JDK 21 #45

merged 4 commits into from
Oct 7, 2024

Conversation

ingleivj
Copy link
Contributor

@ingleivj ingleivj commented Oct 3, 2024 •
edited
Loading

  • har skrudd av lint-sjekken fordi det er så himla mye den klager på
  • withTestApplication er deprecated og bør tas tak i ✅
  • Locations burde vært migrert til Resources, ref https://ktor.io/docs/server-locations.html

Har ikke testet appen som sådan :)

@ingleivj ingleivj marked this pull request as ready for review October 3, 2024 12:12
eirslett
eirslett approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@eirslett eirslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skal være mulig å teste ved å bruke vtp-pensjon, men jeg husker ikke hvordan!

mortennormann
mortennormann approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@mortennormann mortennormann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg syns det ser bra nok ut til å begynne å teste det i dev

@ingleivj
Copy link
Contributor Author

ingleivj commented Oct 4, 2024

Snurrer i dev nå, etter å ha fikset en forglemmelse og 2x fjernet-for-mye!

@ingleivj ingleivj merged commit 02d6d7e into main Oct 7, 2024
@ingleivj ingleivj deleted the feature/jdk21-ktor2 branch October 7, 2024 08:47
ingleivj added a commit that referenced this pull request Oct 7, 2024
@ingleivj
Revert "Migrated to ktor 2, kotlin 2, JDK 21 (#45)"
eebad09 
This reverts commit 02d6d7e.
ingleivj added a commit that referenced this pull request Oct 22, 2024
@ingleivj
Reapply "Migrated to ktor 2, kotlin 2, JDK 21 (#45)"
4cdbebe 
This reverts commit eebad09.
ingleivj added a commit that referenced this pull request Oct 22, 2024
@ingleivj
Reapply "Migrated to ktor 2, kotlin 2, JDK 21 (#45)"
d303fd1 
This reverts commit eebad09.
ingleivj added a commit that referenced this pull request Oct 23, 2024
@ingleivj
Oppgradere til Ktor2, take 2 (#50)
ac77fd6 
* Reapply "Migrated to ktor 2, kotlin 2, JDK 21 (#45)"

This reverts commit eebad09.

* Oppdatert AxsysClient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortennormann mortennormann mortennormann approved these changes

+1 more reviewer

@eirslett eirslett eirslett approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ingleivj @eirslett @mortennormann