Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/5 ebs findings prop #160

Merged
merged 2 commits into from
Feb 9, 2019
Merged

Conversation

Aboisier
Copy link
Contributor

@Aboisier Aboisier commented Feb 7, 2019

This PR implements findings for EBS snapshots from #5.

  • Added method which calculates the most recent snapshot for each volume
  • Added attributes in the EBS snapshots dashboard

Please review the proprietary PR as well.

@Aboisier Aboisier changed the base branch from master to develop February 7, 2019 21:27
@Aboisier Aboisier self-assigned this Feb 7, 2019
@Aboisier Aboisier added enhancement New feature or request component-provider-aws Affects AWS provider labels Feb 7, 2019
@Aboisier Aboisier added this to the Iteration #2 milestone Feb 7, 2019
@codecov-io
Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #160 into develop will decrease coverage by 0.02%.
The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #160      +/-   ##
===========================================
- Coverage    30.28%   30.25%   -0.03%     
===========================================
  Files           66       66              
  Lines         4316     4323       +7     
===========================================
+ Hits          1307     1308       +1     
- Misses        3009     3015       +6
Impacted Files Coverage Δ
ScoutSuite/providers/aws/provider.py 10.95% <14.28%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347d65b...6b3f9e6. Read the comment docs.

@Aboisier Aboisier merged commit 907c8ba into develop Feb 9, 2019
@Aboisier Aboisier deleted the feature/5-ebs-findings-prop branch February 9, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-provider-aws Affects AWS provider enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants