#28 align develop branch with latest main #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: agriffit <aidan.griffiths@bom.gov.au>
#20) * Implement gather_dimensions for reducing no dimensions and preserving all dimensions * Implement more checks in gather_dimensions * Distinguish the error messages for preserving a nonexistent dimension from reducing a nonexistent dimension * Standardise set handling logic * Refactor tests for clarity * Add additional clear basic tests for reduce and preserve
* PyTest action * Rename action to "Unit Tests" * Use python version correctly in action * Use Python version in job name --------- Signed-off-by: tennlee <134973832+tennlee@users.noreply.github.com>
|
@tennlee, might be good to make a PR rule where there should be at least 1 reviewer/approval required to merge to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tennlee and @HCookie, the RMSE branch is held up until we align develop with the latest
mainbranch. This is caused by a few PRs which have applied tomaindirectly without going throughdevelopfirst. Ideally, we should strive for all PRs to come throughdevelopand then @tennlee can periodically approve and merge the dev changes intomain.Thanks.