Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace setuptools for hatchling pkg build backend #7

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

aidanjgriffiths
Copy link
Collaborator

@tennlee, here's the build backend process for hatchling. This took a while to debug unfortunately, seems like using [tool.hatch.build.include] doesn't work in the same way as setuptools does. I could get the desired behaviour with just using exclude but just wanted to make you aware of an existing issue.

@aidanjgriffiths aidanjgriffiths linked an issue Jun 9, 2023 that may be closed by this pull request
@aidanjgriffiths
Copy link
Collaborator Author

@tennlee, hatch also contains its own virtual environment manager and versioning commands which seems handy for the dev dependencies. I am also adding hatch-vcs for the build deps to replicate the setuptools-scm versioning behaviour

@aidanjgriffiths
Copy link
Collaborator Author

aidanjgriffiths commented Jun 9, 2023

hatch-vcs isn't quite up to the configurability that setuptools-scm has so I'm not going to include it in the build deps. Standalone hatch version does what we need.

Usage for bumping versions

@aidanjgriffiths aidanjgriffiths force-pushed the 6-replace-setuptools-with-hatchling-for-pkg-build branch from 6573859 to c1a08b3 Compare June 9, 2023 03:38
Copy link
Collaborator

@tennlee tennlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - happy to move to hatch

@tennlee tennlee merged commit 474a8e6 into main Jun 9, 2023
tennlee added a commit that referenced this pull request Aug 21, 2023
* chore: swap setuptools for hatchling pkg build backend (#7)

Co-authored-by: agriffit <aidan.griffiths@bom.gov.au>

* doc: Update example in README (#15)

* Implement gather_dimensions for reducing no dimensions and preserving… (#20)

* Implement gather_dimensions for reducing no dimensions and preserving all dimensions
* Implement more checks in gather_dimensions
* Distinguish the error messages for preserving a nonexistent dimension from reducing a nonexistent dimension
* Standardise set handling logic
* Refactor tests for clarity
* Add additional clear basic tests for reduce and preserve

* PyTest action (#25)

* PyTest action
* Rename action to "Unit Tests"
* Use python version correctly in action
* Use Python version in job name

---------

Signed-off-by: tennlee <134973832+tennlee@users.noreply.github.com>

---------

Signed-off-by: tennlee <134973832+tennlee@users.noreply.github.com>
Co-authored-by: agriffit <aidan.griffiths@bom.gov.au>
Co-authored-by: tennlee <134973832+tennlee@users.noreply.github.com>
@tennlee tennlee deleted the 6-replace-setuptools-with-hatchling-for-pkg-build branch March 29, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace setuptools with hatchling for pkg build
2 participants