Modified validation of webhook URL to allow optional service/ #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s used by Slack's Incoming Webhooks app (https://slack.com/apps/A0F7XDUAZ-incoming-webhooks)
|
Regex looks sane, but I'll add a test case just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified validation of webhook URL to allow optional service/ which is used by Slack's Incoming Webhooks app (https://slack.com/apps/A0F7XDUAZ-incoming-webhooks). Using Slack's Incoming Webhooks app has the advantage that it can be used for multiple purposes, and due to slack limiting the number of integrations for free accounts its a good idea to reuse these integrations where possible.