Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume server supports all test types #216

Merged
merged 1 commit into from
Feb 17, 2017
Merged

Don't assume server supports all test types #216

merged 1 commit into from
Feb 17, 2017

Commits on Jan 7, 2017

  1. Don't assume server supports all test types 

    The NDT client assumes that the server supports all test types and the
official NDT server respects this assumption.

However, the [neubot/botticelli](https://github.com/neubot/botticelli)
server only implements TEST_META, TEST_S2C, and TEST_S2C.

Therefore, when using the NDT client with a botticelli server, the
client crahes in processing the results of the TEST_MID that however
has not been executed.

Fix by making sure that, when processing results, we use a bitmak where
only bits corresponding to tests that run are actually set.

(There is also another reason why NDT client crashes when testing with
botticelli, addressed by neubot/botticelli#18.)

Problems between NDT client and botticelli reported by @nkinkade, thanks!
    @bassosimone
    bassosimone committed Jan 7, 2017
    Configuration menu
    Copy the full SHA
    91e152d View commit details
    Browse the repository at this point in the history