Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break out into test_constellation_edge_cases #1

Merged
merged 1 commit into from
Oct 29, 2021
Merged

break out into test_constellation_edge_cases #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion astropy/coordinates/tests/test_funcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ def test_sun():
assert np.all(np.abs(gcrs2.dec - [23.5, 0, -23.5]*u.deg) < 1*u.deg)


@pytest.mark.xfail
def test_constellations(recwarn):
from astropy.coordinates import ICRS, FK5, SkyCoord
from astropy.coordinates.funcs import get_constellation
Expand Down Expand Up @@ -63,12 +62,18 @@ def test_constellations(recwarn):
assert boores == 'Boötes'
assert isinstance(boores, str) or getattr(boores, 'shape', None) == tuple()


@pytest.mark.xfail
def test_constellation_edge_cases():
from astropy.coordinates import FK5
from astropy.coordinates.funcs import get_constellation
# Test edge cases close to borders, using B1875.0 coordinates
# Look for HMS / DMS roundoff-to-decimal issues from Roman (1987) data
# as documented in https://github.com/astropy/astropy/issues/9855
# The actual boundary on the west side of Orion at Dec +3.0 is
# 06h14m30 == 6.2416666666666...
ras = [6.24100, 6.24160, 6.24166, 6.24168]

# aka ['6h14m27.6s' '6h14m29.76s' '6h14m29.976s' '6h14m30.048s']
decs = [3.0, 3.0, 3.0, 3.0]
shortnames = ['Ori', 'Ori', 'Ori', 'Mon']
Expand Down