Skip to content

Conversation

ckipp01
Copy link
Contributor

@ckipp01 ckipp01 commented Aug 30, 2022

No functionality here should change. The only difference you'll notice
is that you'll not be publishing SNAPSHOT versions on merge to main.

No functionality here should change. The only difference you'll notice
is that you'll not be publishing SNAPSHOT versions on merge to main.
mill-version: 0.10.7

- name: Publish
run: mill -j 0 -k -i --disable-ticker io.kipp.mill.ci.release.ReleaseModule/publishAll
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I see this different for every CI I look at. I see you weren't using -i, how come? I see you use --disable-ticker, does that save speed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you weren't using -i, how come?

just a mistake on my end

I see you use --disable-ticker, does that save speed?

It makes logs less verbose imho. Plus I think @keynmol was the one to implement --disable-ticker on mill, and it's important to make him feel like people care about what he builds^^

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's purely for my ego.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, I'll start using it immediately then.

def scalafmt() = T.command(reformat())
def fmt() = T.command(reformat())
def refreshedEnv = T.input(T.ctx().env)
def publishVersion = T {
if (refreshedEnv().contains("CI")) VcsVersion.vcsState().format()
if (refreshedEnv().contains("CI")) super.publishVersion()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under the hood mill-ci-release is using this plus some goodies to add on -SNAPSHOT. For now I manually do that until I get the ok to add it lefou/mill-vcs-version#62.


- name: Run tests
run: |
mill -k --disable-ticker __.resolvedIvyDeps &&
mill -k --disable-ticker mill.scalalib.scalafmt.ScalafmtModule/checkFormatAll __.sources &&
mill -j 0 -k --disable-ticker __.test

- name: Set up GPG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Baccata Baccata merged commit 69b57b9 into neandertech:main Aug 31, 2022
@ckipp01 ckipp01 deleted the mill-ci-release branch August 31, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants