-
Notifications
You must be signed in to change notification settings - Fork 6
chore(ci): start using mill-ci-release #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No functionality here should change. The only difference you'll notice is that you'll not be publishing SNAPSHOT versions on merge to main.
mill-version: 0.10.7 | ||
|
||
- name: Publish | ||
run: mill -j 0 -k -i --disable-ticker io.kipp.mill.ci.release.ReleaseModule/publishAll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like I see this different for every CI I look at. I see you weren't using -i
, how come? I see you use --disable-ticker
, does that save speed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you weren't using -i, how come?
just a mistake on my end
I see you use --disable-ticker, does that save speed?
It makes logs less verbose imho. Plus I think @keynmol was the one to implement --disable-ticker
on mill, and it's important to make him feel like people care about what he builds^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's purely for my ego.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn, I'll start using it immediately then.
def scalafmt() = T.command(reformat()) | ||
def fmt() = T.command(reformat()) | ||
def refreshedEnv = T.input(T.ctx().env) | ||
def publishVersion = T { | ||
if (refreshedEnv().contains("CI")) VcsVersion.vcsState().format() | ||
if (refreshedEnv().contains("CI")) super.publishVersion() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under the hood mill-ci-release is using this plus some goodies to add on -SNAPSHOT
. For now I manually do that until I get the ok to add it lefou/mill-vcs-version#62.
|
||
- name: Run tests | ||
run: | | ||
mill -k --disable-ticker __.resolvedIvyDeps && | ||
mill -k --disable-ticker mill.scalalib.scalafmt.ScalafmtModule/checkFormatAll __.sources && | ||
mill -j 0 -k --disable-ticker __.test | ||
|
||
- name: Set up GPG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
No functionality here should change. The only difference you'll notice
is that you'll not be publishing SNAPSHOT versions on merge to main.