Skip to content

fix(ci): ensure -i comes first #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Conversation

ckipp01
Copy link
Contributor

@ckipp01 ckipp01 commented Aug 31, 2022

Screwed this up before.

The release attempt failed with

io.kipp.mill.ci.release.ReleaseModule.setupEnv Missing PGP_SECRET. Make sure you have it set.

I pull this from:

        PGP_SECRET: ${{ secrets.PGP_SECRET }}

Can you also double check that secrets.PGP_SECRET is correct?

@Baccata
Copy link
Contributor

Baccata commented Aug 31, 2022

I doubled checked and it is the correct secret. It may have been related to the wrong location of -i. Let's try again

@Baccata Baccata merged commit 118c998 into neandertech:main Aug 31, 2022
@ckipp01 ckipp01 deleted the fixRelease branch August 31, 2022 07:04
@ckipp01
Copy link
Contributor Author

ckipp01 commented Aug 31, 2022

Noice, it looks to have worked. It published 0.0.0-1-118c99-SNAPSHOT though, which is not what I expected 🤔

@keynmol
Copy link
Contributor

keynmol commented Aug 31, 2022

Fetch depth is probably wrong?

@keynmol
Copy link
Contributor

keynmol commented Aug 31, 2022

I.e. see https://github.com/neandertech/langoustine/blob/main/.github/workflows/ci.yml#L23-L25

Otherwise the tags are not fetched. It's a classic sbt-ci-release manoeuvre :D

@ckipp01
Copy link
Contributor Author

ckipp01 commented Aug 31, 2022

I.e. see https://github.com/neandertech/langoustine/blob/main/.github/workflows/ci.yml#L23-L25

Otherwise the tags are not fetched. It's a classic sbt-ci-release manoeuvre :D

haha, I just saw this as well. I sent in a pr adding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants