Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "main" instead of start function #244

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Use "main" instead of start function #244

merged 1 commit into from
Mar 5, 2024

Conversation

aborg-dev
Copy link

This allows us to avoid abusing "start" section which has a special meaning in WASM and also makes it easier to generate the correct WASM module for Rust programs where adding "start" section in not trivial.

@aborg-dev aborg-dev requested review from nagisa and mooori March 5, 2024 14:35
@aborg-dev aborg-dev mentioned this pull request Mar 5, 2024
Closed
mooori
mooori approved these changes Mar 5, 2024
View reviewed changes
Copy link

@mooori mooori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it should be documented that zkASM codegen expects a module to export a main function, possibly in:

  • The doc comment of zkasm_codegen::generate_zkasm
  • Somewhere in docs/zkasm

cranelift/filetests/src/zkasm_codegen.rs Show resolved Hide resolved
@aborg-dev
Use "main" instead of start function
c72b75f 
This allows us to avoid abusing "start" section which has a special
meaning in WASM and also makes it easier to generate the correct WASM
module for Rust programs where adding "start" section in not trivial.
@aborg-dev aborg-dev enabled auto-merge March 5, 2024 16:34
@aborg-dev aborg-dev added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit 207336a Mar 5, 2024
24 checks passed
@aborg-dev aborg-dev deleted the start_to_main branch March 5, 2024 17:18
@mooori mooori mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooori mooori mooori approved these changes

@nagisa nagisa Awaiting requested review from nagisa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aborg-dev @mooori