Remove ClojureExec and rely on JavaExec #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we don't really need the
ClojureExecandClojureExecActionDoing some debugging, found out that we never reach the following:
https://github.com/nebula-plugins/nebula-clojure-plugin/blob/master/src/main/groovy/nebula/plugin/clojuresque/tasks/ClojureExecAction.groovy#L57
https://github.com/nebula-plugins/nebula-clojure-plugin/blob/master/src/main/groovy/nebula/plugin/clojuresque/tasks/ClojureExec.groovy#L150
Actually, looks like we only set main and args here: https://github.com/nebula-plugins/nebula-clojure-plugin/blob/master/src/main/groovy/nebula/plugin/clojuresque/tasks/ClojureExecAction.groovy#L49 which can be achieved as part of
project.javaexechttps://github.com/nebula-plugins/nebula-clojure-plugin/compare/exceptions-test?expand=1 branch contains
RuntimeExceptionson the code mentioned above and we can see tests passing -> https://travis-ci.org/nebula-plugins/nebula-clojure-plugin/builds/569481026 and https://travis-ci.org/nebula-plugins/nebula-clojure-plugin/builds/569482484