Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojure Tasks: Cleanup Internal properties that should not be marked as Optional #30

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

rpalcolea
Copy link
Member

This is to allow compatibility with future versions of Gradle:


Welcome to Gradle 6.3-20200128230909+0000!

Starting a Gradle Daemon (subsequent builds will be faster)

> Configure project :
Inferred project: nebula-clojure-plugin, version: 9.4.0-dev.1.uncommitted+53f227f

> Task :validatePlugins FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':validatePlugins'.
> Plugin validation failed. See https://docs.gradle.org/6.3-20200128230909+0000/userguide/more_about_tasks.html#sec:task_input_output_annotations for more information on how to annotate task properties.
   > Warning: Type 'ClojureCompile': property 'jvmOptions' annotated with @Internal should not be also annotated with @Optional.
   > Warning: Type 'ClojureDoc': property 'jvmOptions' annotated with @Internal should not be also annotated with @Optional.
   > Warning: Type 'ClojureRepl': property 'jvmOptions' annotated with @Internal should not be also annotated with @Optional.
   > Warning: Type 'ClojureRun': property 'jvmOptions' annotated with @Internal should not be also annotated with @Optional.
   > Warning: Type 'ClojureTest': property 'tests' annotated with @Internal should not be also annotated with @Optional.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.17% when pulling 7b99978 on cleanup-tasks-internal-properties into 53f227f on master.

@rpalcolea rpalcolea merged commit 99d733f into master Jan 28, 2020
@rpalcolea rpalcolea deleted the cleanup-tasks-internal-properties branch January 28, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants