RPC server bind address

[nvi9]

Would it be possible to use InternetAddress.loopbackIPv4 as the address on the following line?

flutter_single_instance/lib/flutter_single_instance.dart

Line 212 in 91ee84e

await _server!.serve(port: 0);

gRPC binds the server socket to InternetAddress.anyIPv4 by default (when address is null) and that can trigger firewall warnings on Windows.

If binding to InternetAddress.anyIPv4 is needed or was intentional, adding a new optional argument to the FlutterSingleInstance constructor would also be a good solution.

[mcquenji]

Yes that was intentional to prevent conflicts with other apps that may also be using this package. I can expose it the init function tho

[nvi9]

Sorry, maybe I wasn't specific enough, this issue is about changing

await _server!.serve(port: 0); 

to

await _server!.serve(address: InternetAddress.loopbackIPv4, port: 0);

The fallback for address in gRPC is InternetAddress.anyIPv4 (source). This is equal to listening on 0.0.0.0, which means the server is accessible from any other device (if the firewall allows it), this is how eg. web servers usually work. Providing InternetAddress.loopbackIPv4 equals to listening on 127.0.0.1, this means only connections coming from the same host are accepted. I suppose the latter is the desired behavior in the case of this package.

I had no problem with port: 0, picking an available port on localhost is the best way to avoid possible failures.

[mcquenji]

ohh my bad, yeah I'll change it to the loopback address. not sure how i managed to misunderstand that 😅