QuickCppLibSetupProject.cmake: Fix safe-stack check #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the typo in `-fsanitize=safe-stack` flag. The flag value is `safe-stack` and not `safestack` as it was used in the project.
See:
```
root@6e0967fe1290:/# clang --version
Debian clang version 15.0.1-++20220921072637+b73d2c8c720a-1~exp1~20220921072648.64
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm-15/bin
root@6e0967fe1290:/# cat a.c
int main() {}
root@6e0967fe1290:/# clang -fsanitize=safe-stack a.c
root@6e0967fe1290:/# clang -fsanitize=safestack a.c
clang: error: unsupported argument 'safestack' to option '-fsanitize='
```
BurningEnlightenment
approved these changes
Dec 27, 2022
| set(SAFESTACK_COMPILE_FLAGS -fsanitize=safestack) | ||
| set(SAFESTACKLINK_FLAGS -fsanitize=safestack) | ||
| set(SAFESTACK_COMPILE_FLAGS -fsanitize=safe-stack) | ||
| set(SAFESTACKLINK_FLAGS -fsanitize=safe-stack) |
There was a problem hiding this comment.
@ned14 we should probably fix the typo in SAFESTACKLINK_FLAGS/introduce the correct spelling and remove the broken one in a few months. However, I cannot estimate how far usage of this variable has spread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the typo in
-fsanitize=safe-stackflag. The flag value issafe-stackand notsafestackas it was used in the project.See: