Skip to content

C tracer: lookups fail in "should_trace_cache" #374

Closed
@nedbat

Description

@nedbat

Originally reported by sbehnel (Bitbucket: sbehnel, GitHub: Unknown)


The C tracer misuses the "should_trace_cache" to store two different things: Disposition objects and True/False, which makes later lookups fail with an AttributeError because True/False don't have a "trace" attribute. I attached a fix. Not sure if it's the correct one.

One thing I'm unsure about is whether the object returned from the cache lookup ("included") should be used as the new disposition object instead of the current one. But my guess is it shouldn't.


Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingrun

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions