Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage pip default installation for python 3.8 does not include c extensions #949

Closed
andrewgill-dev opened this issue Feb 28, 2020 · 6 comments
Labels
bug fixed

Comments

@andrewgill-dev
Copy link

@andrewgill-dev andrewgill-dev commented Feb 28, 2020

Describe the bug
When installing coverage via pip install coverage the version available for windows does not have c extensions compiled.

To Reproduce
How can we reproduce the problem?

  1. What version of Python are you using? 3.8 (works fine in 3.7)
  2. What version of coverage.py are you using? 5.0.3
  3. What code are you running? coverage --version

run pip install coverage this works fine under 3.7 but under 3.8 it installs without c extensions making it incredibly slow.

Expected behavior
The default pip installed version of coverage should be compiled with c extensions.

Additional context
It is possible to use the compiled wheel from https://www.lfd.uci.edu/~gohlke/pythonlibs/#coverage, however if you have a cicd which runs tox and creates a new virtual environment it will install the without c extensions version and take 6-10 times as long to complete tests.

@andrewgill-dev andrewgill-dev added the bug label Feb 28, 2020
@andrewgill-dev
Copy link
Author

@andrewgill-dev andrewgill-dev commented Feb 28, 2020

This issue appears to be caused by the windows wheel for python 3.8 having the m ABI flag, which I believe should be removed for all python 3.8 wheel distributions.

@mjpieters
Copy link

@mjpieters mjpieters commented Feb 28, 2020

Related pip issue: pypa/pip#6885, pip will no longer consider cp38m wheels.

@mjpieters
Copy link

@mjpieters mjpieters commented Feb 28, 2020

I think that all that is needed is a newer version of wheel, see pypa/wheel#303

@mjpieters
Copy link

@mjpieters mjpieters commented Feb 28, 2020

I've confirmed that a newer version of wheel should fix this. Currently coverge.py uses 0.33.1:

wheel==0.31.1

but the 3.8 fixes dropping the m flag were part of 0.33.6.

@nedbat
Copy link
Owner

@nedbat nedbat commented Feb 29, 2020

Fixed in 907f0e8.

@nedbat nedbat closed this as completed Feb 29, 2020
@nedbat nedbat added the fixed label Feb 29, 2020
@nedbat
Copy link
Owner

@nedbat nedbat commented Mar 17, 2020

This is now available in coverage v5.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed
Projects
None yet
Development

No branches or pull requests

3 participants