Memoize a syscall-intensive function #897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds memoization to the abs_file function, speeding up coverage collection in a significative way. This was originally done to improve the number of executions per second of [pythonfuzz](https://github.com/fuzzitdev/pythonfuzz), with the original benchmark available [here](fuzzitdev/pythonfuzz#9), yielding roughly 55% more performances.
|
Mh, apparently pythonfuzz is using an old version of coverage.py, making this improvement kinda irrelevant, sorry about the noise. |
|
@jvoisin Thanks anyway, I appreciate the effort. The description had me a little excited that you found an improvement! :) |
|
Well, worse case, it's still a valid, easy, but unfortunately minor improvement :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds memoization to the abs_file function, speeding up coverage
collection in a significative way.
This was originally done to improve the number of executions per second of
pythonfuzz, with the original
benchmark available here,
yielding roughly 55% more performances.