Improve the performances of SqliteDb._connect #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the self.filename attribute doesn't change during the lifetime of a SqliteDb object, we can move its relpath transformation in the init method, instead of doing it every time _connect is called, resulting in a ~30% performances gain.
|
I did some profiling: Before: After: |
Codecov Report
@@ Coverage Diff @@
## master #912 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 86 86
Lines 12026 12026
Branches 1203 1203
=======================================
Hits 11319 11319
Misses 572 572
Partials 135 135
Continue to review full report at Codecov.
|
|
Thanks! I'll add you to the contributors list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
self.filenameattribute doesn't change during the lifetime of aSqliteDbobject, we can move itsrelpathtransformation in the__init__method, instead of doing it every time _connect is called, resulting in a ~30% performances in the_connectmethod.