Skip to content

Conversation

technophilist
Copy link
Contributor

@technophilist
Copy link
Contributor Author

It's been more than a month since I first created this pr. I request someone to have a look at it.

@a93a
Copy link
Collaborator

a93a commented Feb 24, 2023

Hi!

There are some conflicts. 51 n-queens already exists in the repo, but you can still contribute for problem 17. Also, there is some conflicting issues with the Readme file.

Could you also rename your file to follow the repo naming conventions? For filenames, it's <language>/<problem-number>-name-of-problem.<language-extension> (e.g. java/0001-two-sum.java)

Thanks!

@technophilist
Copy link
Contributor Author

I've resolved the conflicts in the readme file and removed the solution for N-Queens.

@a93a
Copy link
Collaborator

a93a commented Feb 25, 2023

Thank you very much for your contribution. I changed the filename for you. But in the future please use the naming convention. And apologies that it took so long to review your PR. Thank you.

@a93a a93a merged commit 919331c into neetcode-gh:main Feb 25, 2023
@a93a
Copy link
Collaborator

a93a commented Feb 25, 2023

If you are doing more Kotlin submissions in the future, please assign me to it and I will take a look ASAP :)

@technophilist
Copy link
Contributor Author

Thank you very much for your contribution. I changed the filename for you. But in the future please use the naming convention. And apologies that it took so long to review your PR. Thank you.

Thank you. Apologies for not using the correct format. I've been contributing to this repo for quite some time, and I don't remember using leading 0's in the file name and also using all lowercase letters. I've just noticed that the repo follows this convention now. I'll make sure that I follow this naming convention in the future 👍🏻

@a93a
Copy link
Collaborator

a93a commented Feb 27, 2023

No need to apologise! You are correct, I think neetcode changed it a month ago or so (after you've made this PR!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants