Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add C4GH_PASSPHRASE as an option #119

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

blankdots
Copy link
Contributor

@blankdots blankdots commented Feb 21, 2024

  • bump version to 1.9.0
  • add C4GH_PASSPHRASE env var as an option for passing password to secret key
  • update docs

@blankdots blankdots requested a review from a team February 21, 2024 11:40
@blankdots blankdots self-assigned this Feb 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a587c8) 69.03% compared to head (df50daf) 69.72%.

❗ Current head df50daf differs from pull request most recent head 187ad0d. Consider uploading reports for the commit 187ad0d to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   69.03%   69.72%   +0.68%     
==========================================
  Files           6        6              
  Lines         872      862      -10     
==========================================
- Hits          602      601       -1     
+ Misses        149      141       -8     
+ Partials      121      120       -1     
Flag Coverage Δ
unittests 69.72% <100.00%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blankdots blankdots requested review from jbygdell and a team February 21, 2024 11:56
@jbygdell
Copy link
Contributor

closes #118

internal/cli/cli.go Outdated Show resolved Hide resolved
@blankdots blankdots linked an issue Feb 21, 2024 that may be closed by this pull request
@blankdots blankdots requested review from pontus and a team February 21, 2024 12:05
Copy link
Contributor

@aaperis aaperis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! minor typo.

README.md Outdated Show resolved Hide resolved
bump version to 1.9.0
@blankdots blankdots merged commit 0a32f4c into master Feb 22, 2024
6 checks passed
@blankdots blankdots deleted the feature/env-var-password branch February 22, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read passphrase from environment
5 participants