Bugfix/remove deadcode openssl #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feature/env-var-password #120 +/- ##
============================================================
+ Coverage 69.03% 69.72% +0.68%
============================================================
Files 6 6
Lines 872 862 -10
============================================================
- Hits 602 601 -1
+ Misses 149 141 -8
+ Partials 121 120 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
blankdots
force-pushed
the
feature/env-var-password
branch
from
187ad0d
to
16f7437
Compare
blankdots
force-pushed
the
bugfix/remove-deadcode-openssl
branch
from
23d8f58
to
39e6177
Compare
Closed
jbygdell
approved these changes
Feb 22, 2024
pontus
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86
I hope i removed the correct dead code for openssl.
I think this can go into the same version of 1.9.0 that is why it is based in #119
Exclude example folder from tests