Take account of the warnings categories to determine minimum version. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Perl version that introduced each category was determined by
trolling through lib/warnings.pm in each Perl kit beginning with 5.6.0,
making note of when each version first appeared.
I considered using the table in regen/warnings.pl, but some of the
versions in that table seem off to me ('all' is present in 5.6, but the
table says 5.8), and it does not contain retracted warnings categories
(e.g. 'chmod').
Said less tersely: the previous version of the code returned nothing unless some 'use warnings' had an argument. This version returns '5.006' if 'use warnings' is found but no arguments are found. This makes no difference in practice since v5.6 is the assumed minimum, but I'm paranoid and it makes me feel better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Perl version that introduced each category was determined by trolling through lib/warnings.pm in each Perl kit beginning with 5.6.0, making note of when each version first appeared.
I considered using the table in regen/warnings.pl, but some of the versions in that table seem off to me ('all' is present in 5.6, but the table says 5.8), and it does not contain retracted warnings categories (e.g. 'chmod').