Skip to content

Add PHP 8 support #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Add PHP 8 support #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e14fc3
Add PHP 8 support in composer.json
Dec 8, 2020
78f20cd
Update tests for PHP 8
Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"issues": "https://github.com/neilime/php-css-lint/issues"
},
"require": {
"php": "^7.3",
"php": "^7.3 || ^8",
"ext-json": "*"
},
"require-dev": {
Expand Down
37 changes: 29 additions & 8 deletions tests/TestSuite/LinterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,20 @@ class LinterTest extends \PHPUnit\Framework\TestCase
*/
protected $linter;

/**
* @var string
*/
protected $phpVersion;

protected function setUp(): void
{
$this->linter = new \CssLint\Linter();
$php_version = phpversion();
if (version_compare($php_version, '8.0.0', '>=')) {
$this->phpVersion = '8';
} else {
$this->phpVersion = '7';
}
}

public function testConstructWithCustomCssLintProperties()
Expand Down Expand Up @@ -113,20 +124,30 @@ public function testLintStringWithWrongSelectorUnexpectedToken()
public function testLintStringWithWrongTypeParam()
{
$this->expectException(\TypeError::class);
$this->expectExceptionMessage(
'Argument 1 passed to CssLint\Linter::lintString() must be of the type string, array given'
);

if ($this->phpVersion == '8') {
$this->expectExceptionMessage(
'CssLint\Linter::lintString(): Argument #1 ($sString) must be of type string, array given'
);
} else {
$this->expectExceptionMessage(
'Argument 1 passed to CssLint\Linter::lintString() must be of the type string, array given'
);
}
$this->linter->lintString(['wrong']);
$this->assertFalse(false);
}

public function testLintFileWithWrongTypeParam()
{
$this->expectException(\TypeError::class);
$this->expectExceptionMessage(
'Argument 1 passed to CssLint\Linter::lintFile() must be of the type string, array given'
);
if ($this->phpVersion == '8') {
$this->expectExceptionMessage(
'CssLint\Linter::lintFile(): Argument #1 ($sFilePath) must be of type string, array given'
);
} else {
$this->expectExceptionMessage(
'Argument 1 passed to CssLint\Linter::lintFile() must be of the type string, array given'
);
}
$this->linter->lintFile(['wrong']);
}

Expand Down