Skip to content

Conversation

hugopeek
Copy link
Contributor

This intercepts the property name and validates it if it starts with 2 dashes (--can-be-anything). Checking only the first character didn't work, because that interferes with validation of vendor prefixes.

I was unable to get the tests running locally, sorry.. But I added a CSS variable to the valid.css test file, and that validates with this fix applied. So this fixes #80 for me also.

Thank you for providing this useful tool!

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #81 (0ad4230) into main (9a04d83) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #81      +/-   ##
============================================
+ Coverage     95.73%   95.77%   +0.03%     
- Complexity      146      147       +1     
============================================
  Files             4        4              
  Lines           399      402       +3     
============================================
+ Hits            382      385       +3     
  Misses           17       17              
Impacted Files Coverage Δ
src/CssLint/Linter.php 95.01% <100.00%> (+0.05%) ⬆️

@neilime neilime merged commit 08adc7b into neilime:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't accept CSS variables
2 participants