test: add test for networking setup in act

[KnisterPeter]

This test makes sure that the hostname inside of act is resolvable.
This will prevent regressions in the network setup (see #1351, #1022)

Act need to be started with docker network mode host by default. This was changed recently, leading to networking changes. That do break the previous (and expected) behavior.

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ EDITORCONFIG	editorconfig-checker	2		0	0.02s
✅ REPOSITORY	gitleaks	yes		no	2.44s
✅ REPOSITORY	git_diff	yes		no	0.0s
✅ REPOSITORY	secretlint	yes		no	1.01s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

[mergify]

@KnisterPeter this pull request has failed checks 🛠

[mergify]

@KnisterPeter this pull request has failed checks 🛠

[codecov]

Codecov Report

Merging #1375 (b60da5a) into master (4f8da0a) will increase coverage by 6.51%.
The diff coverage is 75.15%.

@@            Coverage Diff             @@
##           master    #1375      +/-   ##
==========================================
+ Coverage   57.50%   64.02%   +6.51%     
==========================================
  Files          32       41       +9     
  Lines        4594     6405    +1811     
==========================================
+ Hits         2642     4101    +1459     
- Misses       1729     2009     +280     
- Partials      223      295      +72     

Impacted Files	Coverage Δ
pkg/model/action.go	0.00% <0.00%> (ø)
pkg/model/step_result.go	0.00% <ø> (ø)
pkg/container/docker_run.go	12.82% <11.63%> (+7.27%)	⬆️
pkg/model/planner.go	48.82% <25.00%> (-1.60%)	⬇️
pkg/model/workflow.go	50.97% <32.14%> (+0.05%)	⬆️
pkg/container/docker_pull.go	33.33% <33.33%> (ø)
pkg/container/file_collector.go	45.87% <45.87%> (ø)
pkg/common/git/git.go	50.00% <47.91%> (ø)
pkg/container/docker_auth.go	47.61% <50.00%> (+2.61%)	⬆️
pkg/exprparser/interpreter.go	73.37% <53.48%> (-0.02%)	⬇️
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[KnisterPeter]

@alex-savchuk Please have a look as well next to the maintainers 🙏

[alex-savchuk]

@KnisterPeter Hello.
Looking at this issue right now.

[alex-savchuk]

Looks good from my point of view.

Main change, as i understand, is that we do not merge nothing if options are empty. With my solution we did.

But i see that test does not catch the problem but only prints data for manual checking.
Maybe we somehow pass hostname of host system as input and verify that it equals to current container hostname?
But maybe current test is enough.

Thank you for catching this problem and providing solution!
I'm traveling right now so wouldn't be able to fix that at least until Wednesday :(

[KnisterPeter]

Main change, as i understand, is that we do not merge nothing if options are empty. With my solution we did.

Exactly. I'm still unsure if that is good enough, but it should restore basic functionality.

But i see that test does not catch the problem but only prints data for manual checking. Maybe we somehow pass hostname of host system as input and verify that it equals to current container hostname? But maybe current test is enough.

The test host $(hostname -f) does fail with your change, but succeeds with the expected state.
At least on linux and GitHub it does, so it should be sufficient I think.

Thank you for catching this problem and providing solution! I'm traveling right now so wouldn't be able to fix that at least until Wednesday :(

No problem, I did not see this issue while I've reviewed your code. This happens all the time as our tests are not yet good enough. A fix is already included in this PR.