Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse types of reusable workflows #1414

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

KnisterPeter
Copy link
Member

This change does parse the different types of workflow jobs.
It is not much by itself but the start to implement reusable
workflows.

Relates to #826

This change does parse the different types of workflow jobs.
It is not much by itself but the start to implement reusable
workflows.

Relates to #826
@KnisterPeter KnisterPeter requested a review from a team as a code owner October 28, 2022 09:34
@KnisterPeter KnisterPeter self-assigned this Oct 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.02s
✅ REPOSITORY gitleaks yes no 2.87s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 1.29s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #1414 (14886b3) into master (4f8da0a) will increase coverage by 6.22%.
The diff coverage is 74.27%.

@@            Coverage Diff             @@
##           master    #1414      +/-   ##
==========================================
+ Coverage   57.50%   63.73%   +6.22%     
==========================================
  Files          32       41       +9     
  Lines        4594     6474    +1880     
==========================================
+ Hits         2642     4126    +1484     
- Misses       1729     2049     +320     
- Partials      223      299      +76     
Impacted Files Coverage Δ
pkg/common/file.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/container/docker_run.go 12.82% <11.58%> (+7.27%) ⬆️
pkg/model/workflow.go 45.65% <23.80%> (-5.26%) ⬇️
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
pkg/container/file_collector.go 43.11% <43.11%> (ø)
pkg/common/git/git.go 50.00% <49.01%> (ø)
pkg/container/docker_auth.go 47.61% <50.00%> (+2.61%) ⬆️
pkg/model/planner.go 48.82% <50.00%> (-1.60%) ⬇️
... and 33 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rickmark
Copy link

This is awesome, I was just forking to try and start implementing this myself!

@KnisterPeter
Copy link
Member Author

@rickmark The work on reusable workflows just started and will need some time.

@mergify mergify bot merged commit 9b95a72 into master Nov 1, 2022
@mergify mergify bot deleted the parse-reusable-workflow-types branch November 1, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants