-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: extra path lost in composite actions #1531
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
@ChristopherHX this pull request has failed checks 🛠 I wonder why I get a timeout, this is one assignment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Thank you
@ChristopherHX this pull request has failed checks 🛠 |
@KnisterPeter you added setup-node in your tests, but we need to fix act or the workflow to not trigger the known ci failure It fails after go test exits with 0, because add-matcher file not found |
Maybe we can replace that action with a simpler just adding to the path? |
yes, just a run step which add the path |
@ChristopherHX this pull request has failed checks 🛠 |
Codecov Report
@@ Coverage Diff @@
## master #1531 +/- ##
==========================================
+ Coverage 61.22% 61.31% +0.09%
==========================================
Files 46 46
Lines 7141 7150 +9
==========================================
+ Hits 4372 4384 +12
+ Misses 2462 2460 -2
+ Partials 307 306 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I didn't 100% understand how composite actions are working in act today. Therefore I forget that the extrapath have to be passed from a different location than static fields like eventjson.
Fixes #1528