Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extra path lost in composite actions #1531

Merged
merged 7 commits into from
Jan 10, 2023

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Dec 20, 2022

I didn't 100% understand how composite actions are working in act today. Therefore I forget that the extrapath have to be passed from a different location than static fields like eventjson.

Fixes #1528

@ChristopherHX ChristopherHX requested a review from a team as a code owner December 20, 2022 18:49
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ REPOSITORY gitleaks yes no 2.65s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.87s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify
Copy link
Contributor

mergify bot commented Dec 20, 2022

@ChristopherHX this pull request has failed checks 🛠

I wonder why I get a timeout, this is one assignment.

@mergify mergify bot added the needs-work Extra attention is needed label Dec 20, 2022
KnisterPeter
KnisterPeter previously approved these changes Dec 20, 2022
Copy link
Member

@KnisterPeter KnisterPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thank you

@mergify
Copy link
Contributor

mergify bot commented Dec 20, 2022

@ChristopherHX this pull request has failed checks 🛠

@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented Dec 20, 2022

@KnisterPeter you added setup-node in your tests, but we need to fix act or the workflow to not trigger the known ci failure

It fails after go test exits with 0, because add-matcher file not found

@KnisterPeter
Copy link
Member

Maybe we can replace that action with a simpler just adding to the path?

@ChristopherHX
Copy link
Contributor Author

yes, just a run step which add the path

@mergify
Copy link
Contributor

mergify bot commented Dec 20, 2022

@ChristopherHX this pull request has failed checks 🛠

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #1531 (8a44dde) into master (4989f44) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1531      +/-   ##
==========================================
+ Coverage   61.22%   61.31%   +0.09%     
==========================================
  Files          46       46              
  Lines        7141     7150       +9     
==========================================
+ Hits         4372     4384      +12     
+ Misses       2462     2460       -2     
+ Partials      307      306       -1     
Impacted Files Coverage Δ
pkg/runner/job_executor.go 88.40% <100.00%> (+0.71%) ⬆️
pkg/runner/step_action_remote.go 90.96% <100.00%> (+0.05%) ⬆️
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Dec 20, 2022
@mergify mergify bot merged commit a53a1c2 into master Jan 10, 2023
@mergify mergify bot deleted the fixExtraPathLostInCompositeActions branch January 10, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PATH is overwritten
3 participants