Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve new-action-cache fetch failure error #2172

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

ChristopherHX
Copy link
Contributor

  • include repoURL and repoRef in error
  • map NoErrAlreadyUptodate to couldn't find remote ref for branchOrtag
    fetch request

test workflow

on: push
jobs:
  _:
    runs-on: ubuntu-latest
    steps:
    - uses: ChristopherHX/ChristopherHX/test@main-2

main-2 doesn't exist, but uses the wildcard query so it returns already uptodate as error due to to ref needing to be fetched

The random tmp branch would never exist so there is no problem mapping it

- include repoURL and repoRef in error
- map NoErrAlreadyUptodate to `couldn't find remote ref` for branchOrtag
  fetch request
@ChristopherHX ChristopherHX requested a review from a team as a code owner January 28, 2024 16:28
Copy link
Contributor

github-actions bot commented Jan 28, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ REPOSITORY gitleaks yes no 2.34s
✅ REPOSITORY git_diff yes no 0.17s
✅ REPOSITORY grype yes no 7.94s
✅ REPOSITORY secretlint yes no 1.31s
✅ REPOSITORY trivy-sbom yes no 0.61s
✅ REPOSITORY trufflehog yes no 6.45s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 1033 lines in your changes are missing coverage. Please review.

Comparison is base (4989f44) 61.22% compared to head (07691fe) 60.94%.
Report is 309 commits behind head on master.

Files Patch % Lines
pkg/artifactcache/handler.go 65.32% 103 Missing and 43 partials ⚠️
pkg/runner/run_context.go 73.37% 75 Missing and 19 partials ⚠️
pkg/runner/expression.go 55.17% 66 Missing and 12 partials ⚠️
pkg/runner/action_cache.go 50.00% 51 Missing and 17 partials ⚠️
pkg/container/docker_run.go 1.47% 66 Missing and 1 partial ⚠️
pkg/container/docker_network.go 0.00% 56 Missing ⚠️
pkg/model/planner.go 28.57% 53 Missing and 2 partials ⚠️
pkg/model/workflow.go 52.72% 42 Missing and 10 partials ⚠️
pkg/runner/reusable_workflow.go 52.47% 42 Missing and 6 partials ⚠️
pkg/common/outbound_ip.go 0.00% 44 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2172      +/-   ##
==========================================
- Coverage   61.22%   60.94%   -0.29%     
==========================================
  Files          46       53       +7     
  Lines        7141     9002    +1861     
==========================================
+ Hits         4372     5486    +1114     
- Misses       2462     3076     +614     
- Partials      307      440     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit 6dd6725 into master Jan 28, 2024
10 checks passed
@mergify mergify bot deleted the fix-improve-new-action-cache-fetch-failure-error branch January 28, 2024 17:02
jmikedupont2 pushed a commit to meta-introspector/act that referenced this pull request Mar 10, 2024
- include repoURL and repoRef in error
- map NoErrAlreadyUptodate to `couldn't find remote ref` for branchOrtag
  fetch request

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants