-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update notebooks #218
update notebooks #218
Conversation
@clewis7 can you confirm that these work with latest fpl from pip? There are users searching the docs for the old line slider numerous times so we really need to merge this. |
not sure why build failed, might have been an issue in something upstream last month, probably caiman. Did a minor commit to trigger CI. |
we are getting the weirdest build failures. The conda installs don't work becaues mamba is being weird. linux: https://github.com/nel-lab/mesmerize-core/actions/runs/5988262161/job/16243264758?pr=218
MacOS: https://github.com/nel-lab/mesmerize-core/actions/runs/5988262158/job/16243264691?pr=218
The pip install runs, but weird issue with running CNMFE:https://github.com/nel-lab/mesmerize-core/actions/runs/5988262157/job/16243264692?pr=218#step:7:1541 E Traceback (most recent call last):
E File "/home/runner/work/mesmerize-core/mesmerize-core/mesmerize_core/algorithms/cnmfe.py", line 89, in run_algo
E cnm = cnm.fit(images)
E File "/opt/hostedtoolcache/Python/3.9.17/x64/lib/python3.9/site-packages/caiman/source_extraction/cnmf/cnmf.py", line 594, in fit
E self.estimates.sn, self.estimates.optional_outputs = run_CNMF_patches(
E File "/opt/hostedtoolcache/Python/3.9.17/x64/lib/python3.9/site-packages/caiman/source_extraction/cnmf/map_reduce.py", line 476, in run_CNMF_patches
E B_tot = np.array(B_tot, dtype=np.float32)
E TypeError: float() argument must be a string or a number, not 'coo_matrix' |
I don't know why the build is failing, but the notebooks worked on my end in a fresh environment with latest pip install of fpl, caiman, and mescore |
I'm merging this for now, the only changes are nbs so we can fix the build issues later, will track in a new issue. |
align notebooks with
fastplotlib
changes#213