Better support for https #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <h4>Parameters</h4> | ||
| {% for name, infos in data.parameters %} | ||
| {% if not infos.readonly %} | ||
| {% if app.request.secure != data.https %} |
There was a problem hiding this comment.
what if the route does not define a scheme requirement, and so can be used for both HTTP and HTTPS ?
It is quite uncommon to have a route forcing you to use HTTP only
There was a problem hiding this comment.
It doesn't work if you haven't set the Access-Control-Allow-Origin header.
You just see a response - or maybe not - depending on the browser you use.
Chrome shows
0 erroras response headers and Firefox shows
0 [Exception... "" nsresult: "0x805e0006 ()" location: "JS frame :: https://domain.local/docs#get--latest :: .send :: line 592" data: no]
I anyways can't really differ between routes forced to http, or routes, where both (secure and unsecure connections) are allowed. Therefore I'd rather keep it like that.
|
Is there a chance, this can get merged soon? :) |
|
@SimonSimCity please squash your commits, and rebase your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a couple of minutes to add a first approach for better SSL support.
One issue I found: If you have a webserver and do not require a scheme, you can actually (according to sf2) use both, but the documentation here requires http. I don't know how I could then probably handle it, if the route requires http and does not allow https.
Therefore you currently cannot test routes, allowing https and http, using a secured connection. Feel free to change that ...
Should fix #266