Sandbox should not be disabled in https whenever a method is not marked as https explictly #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed as https explictly
|
Have you set an additional http-header? I documented what I got when I tried what you're requesting here: Don't you get that error without having set the http-header? |
|
I don't have any additional header, but I don't get an error, I just get the "Please reload the scheme" which is showed while browsing through https because my method is not explicitly marked as 'https'. Hope you see what I mean. |
|
Tried it now. There's no downside for me - just that http-only requests do not work. But as @stof wrote earlier, it's quite unusual to set a request to be http-only ... So, I think this works out. |
|
Thank you @SimonSimCity for checking. @willdurand Can you merge and perform a bug fix release? |
willdurand
added a commit
that referenced
this pull request
Mar 12, 2014
Sandbox should not be disabled in https whenever a method is not marked as https explictly
|
thx |
|
Done. 2.5.1 |
|
thx to you too ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to enhance issue #283 and fixes issue #330.
What I did is to only disable the sandbox whenever a method has been explicitly marked as https and accessed through http. But whenever you access through https a method not explicitly marked it will allow it too!
@SimonSimCity does that break something for you?