Update MT940.php #202
Merged
Update MT940.php #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix on booking date parser
|
We should have a unit test for this. |
ampaze
reviewed
Jan 9, 2020
lib/Fhp/MT940/MT940.php
Outdated
| // try to guess the correct year of the booking date | ||
|
|
||
| $valutaDateTime = new \DateTime($valutaDate); | ||
| $bookingDateTime = new \DateTime($this->getDate($year . substr($transaction, 6, 4))); |
There was a problem hiding this comment.
Ich würde noch
$bookingDate = substr($transaction, 6, 4);
wieder einführen, substr($transaction, 6, 4) kommt mehrfach vor.
There was a problem hiding this comment.
Ja da hast du Recht, ich habe es jetzt $bookingDatePart genannt weil $bookingDate ja schon in anderer Bedeutung verwendet wird.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix on booking date parser