Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset DialogInitialization state when decoupled submission is still pending on login #440

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Philipp91
Copy link
Contributor

Fixes #439, maybe. If it doesn't fix it, let's discard this pull request.

@M-arcus
Copy link

M-arcus commented Jun 27, 2024

@Philipp91
Thank you for the code! 👍
Please merge this and release it as a new version, if possible. Then I can include it into our product.

@Philipp91
Copy link
Contributor Author

Please test it first.

@M-arcus
Copy link

M-arcus commented Jun 27, 2024

I have tested it, the second and all following requests work, also see my answer in #439 (comment):
image

@nemiah nemiah merged commit cd4b624 into nemiah:master Jun 27, 2024
@Philipp91
Copy link
Contributor Author

I have tested it .. also see my answer in #439 (comment)

Oh, sorry for implying you hadn't tested it. That email went to my spam folder and so I hadn't seen the post.

@M-arcus
Copy link

M-arcus commented Jun 27, 2024

No, no, it's my fault, I put the positive result of the PR into the issue comment, not as comment in this PR, where it should have been.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decoupled authentication is no longer possible because of error “Cannot init another dialog”
3 participants