-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New backends #7
New backends #7
Conversation
a54123c
to
2c4f330
Compare
When I added the favicon I noticed it was a little small. Looks like we need to crop everything to have tighter borders (even with the transparent background). I'll look at resizing them this afternoon. |
I think they should be all good now. LGTM? |
FYI I didn't touch anything in |
ed74ea6
to
dd10e0c
Compare
Sorry just getting to this now. I've only looked at the NengoDL stuff, but some comments on those: favicon.ico Size has been reduced from 32x32 to 16x16. I think 32x32 is better, makes the icons crisper. Having the gradient on the N lines also just ends up looking blurry to me at this size, but that might be solved by moving to 32x32. full-light.svg I like the look of adding the gradient to the N lines on this one 👌 full-dark.svg The N lines look washed out to me square-dark.svg The gradient on the N lines looks backwards to me; I think that we want the "brightest" line on top, fading to darker colours at the bottom. icon.png Size increased from 100x100 to 800x800. But for sphinx themes (the most common use for these logos I suspect) the logo width needs to be <= 200 (http://www.sphinx-doc.org/en/master/usage/configuration.html#confval-html_logo). |
I can take a look at making these changes if everyone agrees with Dan |
I went ahead and made the Changes @drasmuss highlighted.
|
We can probably close #4 as well. |
Thanks! All looks good to me now, except for Note that the way I did that originally was by using one base colour and then adjusting the alpha, as opposed to adjusting the RGB. That makes it nice and easy, and means that we only need to worry about one canonical colour for each logo. But I'm not sure if there is a reason to prefer the RGB method. |
Good point, I inverted the gradient on the dark logo, how's this? We can also go lighter, but we risk getting back to the washed out look you cited before. Regarding the RGBa colours, I just used what @p3jawors came up with (I believe he used a website that generates tints based on a colour). It may be easier to use a single colour and adjust alpha, but in that case the background colour comes into play. So I believe using different RBG values will actually give us a more consistent logo across different uses. |
Yeah I was going to say also that browser support for transparency in SVGs is not as good as one might expect, so it would maybe be good to make sure none of them use transparency. Would be good also to write up a short list of rules / guidelines as to how these logos are made, though I don't want that to block the PR. Similarly, it would be good to write the pirmary color's hex code in the |
Personally I would have it start with the "base" orange and then fade to dark from there, rather than starting with the whitish-orange and then fading from there. But I don't feel that strongly about that one, if others like it the other way around I'm totally fine with that. |
Alright, let's get a vote in so we can move forward. We can get that settled and open issues to address the other points from @tbekolay (README details and transparency). |
Ready for another review!
|
I think the base fade to light makes more sense since it's fading towards the white text, the gradient transitions better. |
Added a script that takes the RGB of the base colour and prints the tuning curve colours for each logo.
|
Looks good! I pushed a fixup with some minor changes (simplifying things a bit, pep8 stuff, using numpydoc conventions, and adding some u's because God Save The Queen). |
Was just doing some testing for a different issue, and noticed that despite what the documentation says logos >200px seem to work fine. So what I said above isn't true, it's probably fine to include logos that are a bit higher resolution if we want. |
This has lingered for far too long! I want to get this merged in today or tomorrow, but the main sticking point is to do with filenames. With the way things are set up now, all the svg files in here will end up getting copied to the Also an FYI, in the merge, I will also edit text / add a short note to reflect the decision made in #9. |
Added a commit to take care of those filenames. Now there will be I also renamed all the |
17ab101
to
87e83d1
Compare
25bc4bf
to
16776a4
Compare
There were several discussion ultimately culminating in the set of guidelines included in this commit. The main motivation here was the simplify the process of making new project logos. Simplicity in this case comes at the cost of freedom, but the overwhelming consensus was to favor simplicity and consistency across all Nengo projects. To make logo creation even easier, this commit includes a colour selection script which outputs the colours that should be used in different logo variants based on the primary colour chosen by the project maintainer. A subsequent commit will ensure that existing logos follow these new guidelines. Co-authored-by: Trevor Bekolay <tbekolay@gmail.com>
Old logos now follow the guidelines introduced in a previous commit. The new logos are for: - Nengo SpiNNaker - Nengo Loihi - Nengo FPGA - Nengo Braindrop Co-authored-by: Ben Morcos <morcos.ben@gmail.com>
16776a4
to
c8f9999
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both light and dark, full and square logos for nengo dl, spa, spinnaker, loihi, braindrop, and fpga.