Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New backends #7

Merged
merged 4 commits into from
Dec 5, 2018
Merged

New backends #7

merged 4 commits into from
Dec 5, 2018

Conversation

p3jawors
Copy link
Collaborator

Both light and dark, full and square logos for nengo dl, spa, spinnaker, loihi, braindrop, and fpga.

@bmorcos
Copy link
Contributor

bmorcos commented Sep 17, 2018

When I added the favicon I noticed it was a little small. Looks like we need to crop everything to have tighter borders (even with the transparent background).

I'll look at resizing them this afternoon.

@tbekolay
Copy link
Member

Thanks @bmorcos! And @p3jawors of course for the original logos, with the new website work we'll definitely be wanting to merge these in pretty quickly.

@bmorcos
Copy link
Contributor

bmorcos commented Sep 17, 2018

I think they should be all good now. LGTM?

@bmorcos
Copy link
Contributor

bmorcos commented Sep 17, 2018

FYI I didn't touch anything in general.

@drasmuss
Copy link
Member

drasmuss commented Nov 9, 2018

Sorry just getting to this now. I've only looked at the NengoDL stuff, but some comments on those:

favicon.ico

Size has been reduced from 32x32 to 16x16. I think 32x32 is better, makes the icons crisper. Having the gradient on the N lines also just ends up looking blurry to me at this size, but that might be solved by moving to 32x32.

full-light.svg

I like the look of adding the gradient to the N lines on this one 👌

full-dark.svg

The N lines look washed out to me
old:
dark_old
vs new:
dark_new

square-dark.svg

The gradient on the N lines looks backwards to me; I think that we want the "brightest" line on top, fading to darker colours at the bottom.
old:
square_old
vs new:
square_new

icon.png

Size increased from 100x100 to 800x800. But for sphinx themes (the most common use for these logos I suspect) the logo width needs to be <= 200 (http://www.sphinx-doc.org/en/master/usage/configuration.html#confval-html_logo).

@bmorcos
Copy link
Contributor

bmorcos commented Nov 9, 2018

I can take a look at making these changes if everyone agrees with Dan

@bmorcos
Copy link
Contributor

bmorcos commented Nov 9, 2018

I went ahead and made the Changes @drasmuss highlighted.

  • I made the logo.png 150x150 instead of 100x100
  • I made the favicons 48x48 instead of 32x32

@bmorcos
Copy link
Contributor

bmorcos commented Nov 9, 2018

We can probably close #4 as well.

@drasmuss
Copy link
Member

drasmuss commented Nov 9, 2018

Thanks! All looks good to me now, except for full-dark. Sorry, I couldn't really figure out why it looked off to me before, but now I see. I think the idea with the gradient is that we want it to fade from the base colour (e.g. orange) at the top into the background colour at the bottom. So if the background is white, that means going from orange->light orange (as in full-light or square-light), but if the background is dark, that means going from orange->dark orange (full-dark). Right now it goes from orange->light orange, which is what seems off to me.

Note that the way I did that originally was by using one base colour and then adjusting the alpha, as opposed to adjusting the RGB. That makes it nice and easy, and means that we only need to worry about one canonical colour for each logo. But I'm not sure if there is a reason to prefer the RGB method.

@bmorcos
Copy link
Contributor

bmorcos commented Nov 9, 2018

Good point, I inverted the gradient on the dark logo, how's this?

inverted

We can also go lighter, but we risk getting back to the washed out look you cited before.

Regarding the RGBa colours, I just used what @p3jawors came up with (I believe he used a website that generates tints based on a colour). It may be easier to use a single colour and adjust alpha, but in that case the background colour comes into play. So I believe using different RBG values will actually give us a more consistent logo across different uses.

@tbekolay
Copy link
Member

tbekolay commented Nov 9, 2018

Yeah I was going to say also that browser support for transparency in SVGs is not as good as one might expect, so it would maybe be good to make sure none of them use transparency. Would be good also to write up a short list of rules / guidelines as to how these logos are made, though I don't want that to block the PR. Similarly, it would be good to write the pirmary color's hex code in the README.rst for each project so we don't have to pull out the eyedropper to get it later on. But yeah, those are nice-to-haves but not blocking for merging.

@drasmuss
Copy link
Member

drasmuss commented Nov 9, 2018

Personally I would have it start with the "base" orange and then fade to dark from there, rather than starting with the whitish-orange and then fading from there. But I don't feel that strongly about that one, if others like it the other way around I'm totally fine with that.

@bmorcos
Copy link
Contributor

bmorcos commented Nov 12, 2018

Alright, let's get a vote in so we can move forward.

base colour fade to dark 🎉
image

white fade to base colour ❤️
image

We can get that settled and open issues to address the other points from @tbekolay (README details and transparency).

@bmorcos
Copy link
Contributor

bmorcos commented Nov 14, 2018

Ready for another review!

  • I made sure no logos are using transparency
  • I added the base colour to the project README and added some details to the guidelines file
  • Made the dark logos fade from the base colour to dark

@p3jawors
Copy link
Collaborator Author

I think the base fade to light makes more sense since it's fading towards the white text, the gradient transitions better.

guidelines.rst Outdated Show resolved Hide resolved
@bmorcos
Copy link
Contributor

bmorcos commented Nov 14, 2018

Added a script that takes the RGB of the base colour and prints the tuning curve colours for each logo.

12:18:17 ben@phoenix ~/Git/design new_backends*? ∴ python generate_colors.py 0 192 222
#######  full-light  #######
Top   : #00c0de (0, 192, 222)
Middle: #32cce4 (50, 204, 228)
Bottom: #66d9eb (102, 217, 235)
#######  square-light  #######
Top   : #00c0de (0, 192, 222)
Middle: #32cce4 (50, 204, 228)
Bottom: #66d9eb (102, 217, 235)
#######  full-dark  #######
Top   : #00c0de (0, 192, 222)
Middle: #0099b1 (0, 153, 177)
Bottom: #007385 (0, 115, 133)
#######  square-dark  #######
Top   : #ccf2f8 (204, 242, 248)
Middle: #99e5f1 (153, 229, 241)
Bottom: #66d9eb (102, 217, 235)

@drasmuss
Copy link
Member

Looks good! I pushed a fixup with some minor changes (simplifying things a bit, pep8 stuff, using numpydoc conventions, and adding some u's because God Save The Queen).

@drasmuss
Copy link
Member

drasmuss commented Dec 3, 2018

Was just doing some testing for a different issue, and noticed that despite what the documentation says logos >200px seem to work fine. So what I said above isn't true, it's probably fine to include logos that are a bit higher resolution if we want.

@tbekolay
Copy link
Member

tbekolay commented Dec 4, 2018

This has lingered for far too long! I want to get this merged in today or tomorrow, but the main sticking point is to do with filenames. With the way things are set up now, all the svg files in here will end up getting copied to the _static directory when Sphinx builds the docs, and the filenames will not reflect the project they belong to (i.e., _static will contain full-light.svg, full-light-1.svg etc and it's not clear which project will be which, and whether that will change over time). @drasmuss and I have a few ideas about how to do this, depending on the kinds of hooks that Sphinx provides, which we'll look into today. It shouldn't take long though, so if anyone was hoping to comment / suggest anything on this then now's the time.

Also an FYI, in the merge, I will also edit text / add a short note to reflect the decision made in #9.

@drasmuss
Copy link
Member

drasmuss commented Dec 4, 2018

Added a commit to take care of those filenames. Now there will be nengo-fpga-full-light.svg, nengo-dl-full-light.svg, etc.

I also renamed all the nengo_project names to nengo-project.

@tbekolay tbekolay force-pushed the new_backends branch 2 times, most recently from 25bc4bf to 16776a4 Compare December 4, 2018 22:10
bmorcos and others added 4 commits December 4, 2018 22:51
There were several discussion ultimately culminating in the
set of guidelines included in this commit. The main motivation
here was the simplify the process of making new project logos.
Simplicity in this case comes at the cost of freedom, but
the overwhelming consensus was to favor simplicity and consistency
across all Nengo projects.

To make logo creation even easier, this commit includes a colour
selection script which outputs the colours that should be used
in different logo variants based on the primary colour chosen
by the project maintainer.

A subsequent commit will ensure that existing logos follow these
new guidelines.

Co-authored-by: Trevor Bekolay <tbekolay@gmail.com>
Old logos now follow the guidelines introduced in a
previous commit.

The new logos are for:
- Nengo SpiNNaker
- Nengo Loihi
- Nengo FPGA
- Nengo Braindrop

Co-authored-by: Ben Morcos <morcos.ben@gmail.com>
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a once-over of the logos, all looking good to me, and added more text to the guidelines. It could be improved, but I want to get this merged now so we can start linking to the logos. Thanks for the awesome Inkscaping @p3jawors and @bmorcos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants