Preview4 #4
Merged
Preview4 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make BinarySerializer public * public serialize/deserialize methods Co-authored-by: Harry <harrypierson@ngd.neo.org>
* record historical designation * fix ut * sort * Remove sort * use different key * fix some * Store it as BiEndian * avoid in same block * Optimize * use findrange * optimize index get * Erik's feedback * Fix UT * fix empty sequence * optimize height * fix ut * index * fix ut Co-authored-by: Luchuan <luchuan@ngd.neo.org> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Tommo-L <luchuan@neo.org>
Co-authored-by: Tommo-L <luchuan@neo.org> Co-authored-by: Shargon <shargon@gmail.com>
* add event * add Request event * move Reponse into Finish method * format * optimize * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-authored-by: Erik Zhang <erik@neo.org> * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-authored-by: Erik Zhang <erik@neo.org> * fix * apply erik's feedback * add RequestContract * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-authored-by: Erik Zhang <erik@neo.org> Co-authored-by: Tommo-L <luchuan@neo.org> Co-authored-by: Erik Zhang <erik@neo.org> Co-authored-by: Shargon <shargon@gmail.com>
* Itoa atoi * add base * Update src/neo/SmartContract/ApplicationEngine.Binary.cs Co-authored-by: Erik Zhang <erik@neo.org> * Update src/neo/SmartContract/ApplicationEngine.Binary.cs Co-authored-by: Erik Zhang <erik@neo.org> * Fix ut * Clean code * Update src/neo/SmartContract/ApplicationEngine.Binary.cs Co-authored-by: Erik Zhang <erik@neo.org> * Update src/neo/SmartContract/ApplicationEngine.Binary.cs Co-authored-by: Erik Zhang <erik@neo.org> * Fix ut Co-authored-by: Erik Zhang <erik@neo.org>
* add InsufficientFunds code * add ResponseTooLarge * Update OracleResponseCode.cs * Change values Co-authored-by: Tommo-L <luchuan@neo.org> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Erik Zhang <erik@neo.org>
* If exists * Call onPayment if to it's a smart contract * Increase cost in transfer * Remove Mint check * return * Remove extra args * Drop result * Clean code * Method.Exists * Rename * protected * Update ApplicationEngine.Contract.cs * Fix merge * Add Name in Extra * Name in manifest * Fix UT * dotnet format * Remove Method.Exists * Clean code * Move filed `Name` * Rename * Update null checks * Fix CallFromNativeContract parameters * Update AssetDescriptor.cs * Fix UT * format * Shargon's suggestion * Update src/neo/SmartContract/Native/Tokens/Nep17Token.cs Co-authored-by: Luchuan <luchuan@ngd.neo.org> * Fix Co-authored-by: Erik Zhang <erik@neo.org> Co-authored-by: Luchuan <luchuan@ngd.neo.org>
* Allow to get Verification Result outside core * Use index * Return IEnumerable * Clean code * Revert "Return IEnumerable" This reverts commit 7dd3717. * LoadContract solution * Remove constant * Reuse call * Refactor * Move to LoadContract * Remove double check * Update src/neo/SmartContract/ApplicationEngine.cs Co-authored-by: Erik Zhang <erik@neo.org> * Move to else * Fix LoadContract * Update Helper.cs * Remove empty line * Add packParameters * Use LoadContract in CallContractInternal Co-authored-by: Erik Zhang <erik@neo.org>
* Make KeyBuilder public so neo-debugger can use it * Move namespace * Clean using Co-authored-by: Shargon <shargon@gmail.com>
* Add data to transfer/onPayment * wallet * Fix UT * Remove data from Mint and Burn * Use default value * Remove default parameter in native contract * Remove default parameter Co-authored-by: Erik Zhang <erik@neo.org>
* Call from native contract synchronously * Use native callingScriptHash * Optimize Co-authored-by: Shargon <shargon@gmail.com>
* Check safemethod * Move safe method to Abi * Native safe * Fix merge Co-authored-by: Erik Zhang <erik@neo.org>
* Fix asset symbol * Increase coverage Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Shargon <shargon@gmail.com>
* Refactor activation Index * Improve parse * Fix * Update ManagementContract.cs * IReadOnlyDictionary * Erik's feedback * Optimize Co-authored-by: Erik Zhang <erik@neo.org>
* Rename native contracts * Fix * RoleManagement Co-authored-by: Shargon <shargon@gmail.com>
* .NET 5.0 * Update main.yml * Update main.yml * Update main.yml Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update