Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test workflow for basic neoxp commands #356

Merged
merged 13 commits into from
Nov 22, 2023

Conversation

cschuchardt88
Copy link
Member

Change Log

  • Added workflow for all neoxp commands

@cschuchardt88 cschuchardt88 changed the title Added workflow for all neoxp commands Added workflow for basic neoxp commands Nov 17, 2023
@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Nov 17, 2023

@Liaojinghui @lock9

I need some help with the following:

  • Best way to deploy the list of items below
  • Developing the items in the list below
  • Make issues for the list below (one of you two please)

Some things that are needed for testing are

  • Contracts
    • NEP-11
      • mintable (all access)
      • burnable (all access)
      • Transfer
      • non-divisible (ONLY)
    • NEP-17
      • mintable (all access)
      • burnable (all access)
      • Transfer
    • Basic
      • Storage
      • Events
      • Logs
      • Oracle
      • Call another contract
  • batch file
    • setup.batch
  • xUnit test for contract

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Nov 17, 2023

@lock9
please check https://github.com/neo-project/neo-express/actions/runs/6900496662/job/18773817872?pr=356

See if it meets the basic needs until we get the list done.

You can invoke the tool using the following command: neoxp
Tool 'neo.express' (version '3.6.61-preview-g187fd6bbb0') was successfully installed.

@cschuchardt88 cschuchardt88 marked this pull request as ready for review November 17, 2023 06:27
@cschuchardt88
Copy link
Member Author

when time merge this PR before #357

@Jim8y
Copy link
Contributor

Jim8y commented Nov 17, 2023

@Liaojinghui @lock9

I need some help with the following:

  • Best way to deploy the list of items below
  • Developing the items in the list below
  • Make issues for the list below (one of you two please)

Some things that are needed for testing are

  • Contracts

    • NEP-11

      • mintable (all access)
      • burnable (all access)
      • Transfer
      • non-divisible (ONLY)
    • NEP-17

      • mintable (all access)
      • burnable (all access)
      • Transfer
    • Basic

      • Storage
      • Events
      • Logs
      • Oracle
      • Call another contract
  • batch file

    • setup.batch
  • xUnit test for contract

What you mean by this? Adding UT tests for them?

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Nov 17, 2023

I want to test all the commands in neo-express application in github actions. And i need those things.

I need those contracts created and in addition

I need a contract xunit test see for more detail of what im talking about #322

Also i need someone to create a batch file for the neo-express

If not i guess i could do it all...

@Jim8y
Copy link
Contributor

Jim8y commented Nov 17, 2023

I'll see what I can do, but not sure.

@Jim8y
Copy link
Contributor

Jim8y commented Nov 18, 2023

@cschuchardt88
Copy link
Member Author

@Liaojinghui either way this ready to go for now, just have the basics. Which is good enough for now. The more advanced stuff I'll add later

@cschuchardt88 cschuchardt88 changed the title Added workflow for basic neoxp commands Added test workflow for basic neoxp commands Nov 19, 2023
@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Nov 20, 2023

@Liaojinghui this one is ready

@Jim8y
Copy link
Contributor

Jim8y commented Nov 22, 2023

@cschuchardt88 I know its not relavent, but can you please delete all artifact upload logic and download logic and push to azure logic and change the package direction to myget? I need someone else to do it such that I can merge.

@Jim8y Jim8y merged commit 8bab177 into neo-project:master Nov 22, 2023
2 checks passed
@cschuchardt88
Copy link
Member Author

@Liaojinghui whats the myget link? ngd one?

@Jim8y
Copy link
Contributor

Jim8y commented Nov 22, 2023

Can we do with this one?

run: dotnet nuget push out/*.nupkg -s https://www.myget.org/F/neo/api/v2/package -k ${MYGET_TOKEN} -ss https://www.myget.org/F/neo/symbols/api/v2/package -sk ${MYGET_TOKEN}

@cschuchardt88 cschuchardt88 deleted the standalone-workflow branch November 22, 2023 18:13
@cschuchardt88 cschuchardt88 restored the standalone-workflow branch November 22, 2023 22:39
@cschuchardt88 cschuchardt88 deleted the standalone-workflow branch November 22, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants