Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Update neo nuget #530

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Update neo nuget #530

merged 2 commits into from
Jan 6, 2020

Conversation

shargon
Copy link
Member

@shargon shargon commented Jan 3, 2020

Allow to compile with the last neo changes

@shargon shargon requested a review from erikzhang January 3, 2020 09:40
vncoelho
vncoelho approved these changes Jan 5, 2020
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built with success for neo-cli.

@vncoelho
Copy link
Member

vncoelho commented Jan 5, 2020

@shargon,

maybe remove --rpc from:

# Start neo-cli
spawn dotnet out/neo-cli.dll --rpc

Perhaps RPC is a plugin now and not needed to be passed as a parameter.

vncoelho
vncoelho previously requested changes Jan 5, 2020
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shargon, I think that we need to update the config file as well, because now we do not need port config and other things as well.

EDIT: I just noticed it was already removed.

@vncoelho vncoelho dismissed their stale review January 5, 2020 20:41

already removed

@erikzhang
Copy link
Member

GUI should be fixed too.

@shargon shargon requested a review from vncoelho January 6, 2020 11:23
@vncoelho vncoelho merged commit 22bc06e into master Jan 6, 2020
@vncoelho vncoelho deleted the update-neo branch January 6, 2020 12:03
@cloud8little
Copy link
Contributor

cloud8little commented Jan 7, 2020 •
edited
Loading

Smoke Test Passed:
Test build: neo-node: a137b6f
neo: 3.0.0-CI00844
CLI works well.

  1. Build success
  2. Create/open Wallet
  3. Send transaction via command line
  4. dumpprivkey/ getbestblockhash/ getblockcount/ getnep5balances/ listplugin / getapplicationlog

GUI works well

  1. Build success
  2. Open wallet
  3. Send transaction

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vncoelho vncoelho vncoelho approved these changes

@erikzhang erikzhang Awaiting requested review from erikzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shargon @vncoelho @erikzhang @cloud8little