Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Update dependencies for Performance Plugin #549

Closed
wants to merge 1 commit into from

Conversation

meevee98
Copy link
Contributor

@meevee98 meevee98 commented Mar 9, 2020

Add the PerformanceCounter to be able to use the commands from neo-modules#188

@@ -30,6 +30,7 @@
<ItemGroup>
<PackageReference Include="Neo" Version="3.0.0-CI00855" />
<PackageReference Include="System.ServiceProcess.ServiceController" Version="4.6.0" />
<PackageReference Include="System.Diagnostics.PerformanceCounter" Version="4.7.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an addition of a dependency, not an update

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had problems like this in the past, if a module require a nuget, it's not copied, but we can't solve the problem like this, we should be able to load the dependency with the plugin

#508
#508 (review)

@vncoelho
Copy link
Member

@meevee98, can we close this and proceed with @shargon's suggestion?

@erikzhang erikzhang closed this Nov 16, 2021
@shargon shargon deleted the metrics-plugin branch November 16, 2021 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants