Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Fix plugin commands #557

Merged
merged 5 commits into from
Apr 7, 2020
Merged

Fix plugin commands #557

merged 5 commits into from
Apr 7, 2020

Conversation

shargon
Copy link
Member

@shargon shargon commented Apr 1, 2020

Close #556

@shargon shargon requested a review from nicolegys April 1, 2020 07:33
erikzhang
erikzhang previously approved these changes Apr 1, 2020
@nicolegys
Copy link
Contributor

key.ToLower cannot get the value
image

@shargon
Copy link
Member Author

shargon commented Apr 1, 2020

@nicolegys please take a look again

@nicolegys
Copy link
Contributor

Thank you @shargon . Now it works well.
Do we need to display all the command help information including the plugins when we call help?
Now it looks like this (StatesDumper and PerformanceMonitor are installed):
a bit messy
Or maybe we need to put all the plugin comands in Category Plugin Commands?
image

@shargon
Copy link
Member Author

shargon commented Apr 1, 2020

Both options are good to me, what do you prefer? it's enough with change the category of the plugin command.

@nicolegys
Copy link
Contributor

I prefer to have plugin commands in the Plugin Commands catagory, to make the help information more clearly. And whether the plugins are installed or not, they will not affect the categories of neo-cli itself.

Base Commands:
...
Blockchain Commands:
...
Consensus Commands:
...
Contract Commands:
...
Network Commands:
...
Node Commands:
...
Plugin Commands:
...
Wallet Commands:
...

But maybe the plugin commands need to have their own catagories,like this

neo> help PerformanceMonitor
Block Commands:
        block avgtime [blockCount=1000]
        block sync
        block time <blockIndexOrHash>
        block timesincelast
Check Commands:
        check cpu
        check memory
        check threads
Consensus Commands:
        commit time
        confirmation time
        payload time
Network Commands:
        connected
        ping [ipaddress=null]
        rpc time <url>
Transaction Commands:
        tx avgsize [txCount=1000]
        tx size <transactionHash>

I'm not sure if changing all of their categories to Plugin Commands will make the help information more friendly. Or maybe we need subcategories? What do you think?

@shargon shargon merged commit 004a3b7 into master Apr 7, 2020
@shargon shargon deleted the fix-plugin-command branch April 7, 2020 07:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot call plugin commands
3 participants