This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 146
Check items after copy an array/struct (3x) #204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 79.32% 79.31% -0.02%
==========================================
Files 16 16
Lines 1422 1421 -1
==========================================
- Hits 1128 1127 -1
Misses 294 294
Continue to review full report at Codecov.
|
shargon
changed the title
Check items after copy an array/struct
Check items after copy an array/struct (3x)
Sep 19, 2019
erikzhang
previously approved these changes
Sep 19, 2019
I think that all the VM should have the same behaviour, and this check can ensure that this happend. |
Conflict |
Solved |
steven1227
approved these changes
Sep 26, 2019
vang1ong7ang
approved these changes
Sep 26, 2019
erikzhang
approved these changes
Sep 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acording to the conversation on: https://github.com/neo-project/neo/pull/1100/files with @vang1ong7ang