Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Check items after copy an array/struct (3x) #204

Merged
merged 6 commits into from
Sep 26, 2019
Merged

Conversation

shargon
Copy link
Member

@shargon shargon commented Sep 19, 2019

@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #204 into master will decrease coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   79.32%   79.31%   -0.02%     
==========================================
  Files          16       16              
  Lines        1422     1421       -1     
==========================================
- Hits         1128     1127       -1     
  Misses        294      294
Impacted Files Coverage Δ
src/neo-vm/ExecutionEngine.cs 70.75% <77.77%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6676592...254a7fc. Read the comment docs.

@shargon shargon changed the title Check items after copy an array/struct Check items after copy an array/struct (3x) Sep 19, 2019
erikzhang
erikzhang previously approved these changes Sep 19, 2019
Now when the execution fail, the item still in the stack
Now when the execution fail, the item still in the stack
@erikzhang
Copy link
Member

@shargon Do you think we should skip checking the stack when FAULT? #206

@shargon
Copy link
Member Author

shargon commented Sep 20, 2019

Do you think we should skip checking the stack when FAULT? #206

I think that all the VM should have the same behaviour, and this check can ensure that this happend.

@erikzhang
Copy link
Member

Conflict

@shargon
Copy link
Member Author

shargon commented Sep 26, 2019

Solved

@shargon shargon merged commit ddcabba into master Sep 26, 2019
@shargon shargon deleted the shargon-patch-1 branch September 26, 2019 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants