This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Use ReadOnlySpan<byte>
#219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Nov 9, 2019
shargon
reviewed
Nov 13, 2019
|
|
||
| internal override ReadOnlyMemory<byte> ToMemory() | ||
| { | ||
| throw new NotSupportedException(); |
There was a problem hiding this comment.
Implement it as virtual with this content by default in StackItem?
There was a problem hiding this comment.
It's internal. So it is the same anyway.
shargon
reviewed
Nov 14, 2019
|
|
||
| internal override ReadOnlyMemory<byte> ToMemory() | ||
| { | ||
| return value.IsZero ? ReadOnlyMemory<byte>.Empty : value.ToByteArray(); |
There was a problem hiding this comment.
Maybe we should cache the ToByteArray the first time that will be used, what do you think?
shargon
approved these changes
Nov 14, 2019
|
We can do optimizations later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.