Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hardfork for StrictMode #2881

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

Ashuaidehao
Copy link
Contributor

Close #2873

@superboyiii
Copy link
Member

@roman-khimov @AnnaShaleva @shargon Could you review?

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this fixes the problem.

@superboyiii
Copy link
Member

@vncoelho Bro, need your review as well.

src/Neo/Hardfork.cs Outdated Show resolved Hide resolved
@shargon
Copy link
Member

shargon commented Aug 1, 2023

@Ashuaidehao could you acept the license?

@Ashuaidehao
Copy link
Contributor Author

Ashuaidehao commented Aug 2, 2023

@dotnet-policy-service agree

@superboyiii
Copy link
Member

Merge?

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Aug 3, 2023
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Aug 3, 2023
Follow the neo-project/neo#2881.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@superboyiii
Copy link
Member

@shargon @vncoelho @roman-khimov Merge?

@shargon shargon merged commit 0292ace into neo-project:master Aug 8, 2023
1 check passed
shargon added a commit that referenced this pull request Aug 9, 2023
* Remove extra space (#2878)

* Add Hardfork for StrictMode (#2881)

* init

* rename

* hardfork

* Update ApplicationEngine.Runtime.cs

---------

Co-authored-by: Shargon <shargon@gmail.com>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Aug 9, 2023
Follow the neo-project/neo#2881.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Aug 9, 2023
Follow the neo-project/neo#2881.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Aug 9, 2023
Follow the neo-project/neo#2881.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
shargon added a commit that referenced this pull request Aug 18, 2023
* Check ABI for notifications

* Patch checkabi (#2884)

* Remove extra space (#2878)

* Add Hardfork for StrictMode (#2881)

* init

* rename

* hardfork

* Update ApplicationEngine.Runtime.cs

---------

Co-authored-by: Shargon <shargon@gmail.com>

* Check UTF8 string

* Cleaner way

* Fix Buffer

* Update src/Neo/SmartContract/ApplicationEngine.Runtime.cs

Co-authored-by: Anna Shaleva <anna@nspcc.ru>

---------

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
Co-authored-by: Shine Li <bfshm@qq.com>
Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Anna Shaleva <anna@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StrictMode during contract deploy/update will break the T5 after 3.6 release
6 participants