-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose GetContractState #3161
Expose GetContractState #3161
Conversation
This is required now for query the manifest and nef for native contracts |
Has to be public? |
After this was public, the nef, and the manifest |
@@ -11,7 +11,7 @@ | |||
|
|||
namespace Neo.Persistence | |||
{ | |||
internal class MemoryStoreProvider : IStoreProvider | |||
public class MemoryStoreProvider : IStoreProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jim8y Now that we have two constructors in neoSystem, we need to expose also de provider, otherwise, devpack also fails.
What I am saying is why not make it visible to other sub modules, instead of making this one public. |
@@ -26,6 +26,7 @@ | |||
|
|||
<ItemGroup> | |||
<InternalsVisibleTo Include="Neo.SmartContract.Testing" /> | |||
<InternalsVisibleTo Include="Neo.SmartContract.TestEngine" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, the old testEngine require some internals too
Up to you to decide, but once you make them public, there is no way back, you can not change them at well anymore, and you must maintain them. |
These are good to be public |
Required for neo-project/neo-modules#881