-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new-cli]
Part-1 - Base App
#3372
[new-cli]
Part-1 - Base App
#3372
Conversation
@@ -30,6 +30,7 @@ | |||
<InternalsVisibleTo Include="Neo.SmartContract.Testing" /> | |||
<InternalsVisibleTo Include="Neo.SmartContract.TestEngine" /> | |||
<InternalsVisibleTo Include="Neo.Plugins.RpcServer.Tests" /> | |||
<InternalsVisibleTo Include="neo-cmd" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's strange to me have two clients in the same repo, why don't improve the original one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It as bad as if I were to walk in outer space without a helmet on my head. What I am saying is it is to far gone, and needs to be redesigned anyways. This will solve tons of problems and issue, existing and future ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A whole new CLI will lead to code bloat and confusion for users. We need to improve on the CLI we have (keeping it compatible in the process).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roman-khimov @shargon
All the code you see it the minimum
amount to run
neo-cli
as a true background service
for every OS
all the way upto PART-7
. Most of the code is to be able to interact with the cli
as running as a service
. All this could be added to neo-cli
. But it just is easier to make new application, without hacking together for neo-cli
to continue to work with other versions of neo
core when they come out. Plus this is wanting to merge to branch new-cli
. Once we get to the point of determining release or features or anything else, we can merge to master
. This is a one-in-all solution to neo-express
, neo-cli
, android
, IOS
and different node
types, like archival
, full
, half
, development
. I just don't do this for fun of it. Just filtering out the bad and keeping the good. This could be a a replacement for noo-cli
, But I wouldn't recommend it. Let it be there for users if they want to do.
Maybe use some prefix like newcli to differ the folder for new cli |
This is more of the host for |
Going different route with this. Going to build a |
Description
PART-1
This is for
new-cli
branchFeatures
nuget
)config.json
removed)Fixes
Type of change
Checklist: