Skip to content

Conversation

p123-stack
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@transistive transistive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! THere are a few minor things still left to do which i put in the comments

@exaby73 exaby73 merged commit 9398faa into main Mar 3, 2025
3 checks passed
p123-stack added a commit that referenced this pull request Mar 3, 2025
* main branch

* implemented the unit tests for authentication and objects

* fixed the CI and Psalm

* fixed the CI and Psalm show-infor errors

* removed PersonUnitTest

* implemented unit test

* DEBUG

* DEBUG

* enabled the mocking of final classes in PHPUnit

* enabled the mocking of final classes in PHPUnit

* Debug

* Debug

* Removed the getters from resultCounters

* updated the TransactionUnitTest

* fixed integration test for resultcounters

* fixed integration test

* fixed integration test

* updated tests

* seperated all integration tests

* removed all the final keyword

* DEBUG

* resolved changes according to comments

* resolved changes

* invalidbooktest is created

* Added unit test for ResultRow

* chore: remove invalid import

* psalm info issues are fixed

* Added unit test for ResultRow

* Added unit test for ResultRow

* Added final keyword

* fixed broken test and added schema for phpunit.xml

* updated README.md

* Added final keyword to all neccesary classes

* minor errors

* propertynotsetinconstructor is removed

* fixed all warnings

* add coverage options

* explicitly mark test folder in phpunit tests

* remove coverage filter from phpunit xml

* winp

* Deprecations fixed

* Deprecations fixed

* added a new phunitCoverage.xml file for generating a code coverage report

* added a new phunitCoverage.xml file for generating a code coverage report

* removed phunit.cache file and xml-coverage folder

---------

Co-authored-by: Pratiksha <pratiksha@Pratiksha-Nagels>
Co-authored-by: pratikshazalte69 <pratikshazalte69@gmail.com>
Co-authored-by: Kiran Chandani <kiran@nagels.tech>
Co-authored-by: Ghlen Nagels <ghlen@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants